[Geany-Devel] PairTagHighlighter / Not auto clear previous highlight when click other tag

[Volodymyr Kononenko]

Lex,

Thank for exhaustive answer!
A search with git bisect has shown, that the bug was introduced with
updating Scintilla to 3.3.2:

kvm at dell-e6220 /mnt/doc/devel/geany/geany $ git bisect good
f5588043b7e6bbd9dff5ac37eb37b00a503d192a is the first bad commit
commit f5588043b7e6bbd9dff5ac37eb37b00a503d192a
Author: Colomban Wendling <ban at herbesfolles.org>
Date:   Wed May 22 03:23:57 2013 +0200

    Update Scintilla to version 3.3.2

Similar issue <http://sourceforge.net/p/scintilla/bugs/1604/> I've found on
Scintilla bug tracker was fixed only for win32 - here is the patch
<http://sourceforge.net/p/scintilla/code/ci/23f89aef53c7ab73bdd45ae1302b97698682e3cd>
.
I tried to detect the first Scintilla commit, which introduced the issue,
but I see that merging Scintilla to Geany sources is non-trivial. Build
failed after the first attempt.

Folks, what do you think about it? Is it enough information that it is
Scintilla issue and we need to report it or something was not taken into
account during upgrading to 3.3.2?



On 8 March 2015 at 23:42, Lex Trotman <elextr at gmail.com> wrote:

> cd /somedirectory
> mkdir geany
> cd geany
> git clone https://github.com/geany/geany.git
> cd geany
> git checkout the_version_you_want
> ./autogen.sh --prefix=/somedirectory/geany
> make install
> cd ../bin
> ./geany -c ../config
>
> gives a version of geany completely independent of your system geany
>
> for plugins
>
> cd /somedirectory/geany
>
> git clone https://github.com/geany/geany-plugins.git
> cd geany-plugins
> ./autogen.sh --prefix=/somedirectory/geany
> --with-geany-libdir=/somedirectory/geany/lib
> make install
> cd ../bin
> ./geany -c ../config
>
> and you have the plugins.  Note there is no sudo in the above so you
> can't touch the system install by accident.
>
> For further information see the HACKING file.
>
> Cheers
> Lex
>
> On 9 March 2015 at 04:36, Volodymyr Kononenko <vmkononenko at gmail.com>
> wrote:
> > Hi all,
> >
> > I have received several bugreports about PairTagHighlighter plugin. The
> > subject is described on Github.
> > While debugging I see that plugin is trying to clear highlighting on
> > appropriate ranges, but nothing happens after SCI_INDICATORCLEARRANGE.
> BTW,
> > I've checked, that clearing range is called for the correct indicator.
> >
> > The issue is not reproducible on 1.23.1, while on 1.24.1 it has stable
> > reproducibility.
> >
> > I've found the issue in Scintilla, which I suppose is related to subject.
> > This issue was fixed in Scintilla after 3.4.2. In Geany codebase
> Scintilla
> > was updated to 3.4.4 with 46affaf commit. I want to check if the issue is
> > reproducible on this revision and one revision before.
> >
> > Please, tell me how to build a certain version of Geany and plugin for
> it,
> > because my playing with --with-geany-libdir and --prefix was
> unsuccessful.
> >
> > If you have another ideas why the issue could happen, please let me know.
> > Thanks in advance!
> >
> >
> > --
> > Best regards,
> > Volodymyr Kononenko
> > http://kononenko.ws
> >
> > _______________________________________________
> > Devel mailing list
> > Devel at lists.geany.org
> > https://lists.geany.org/cgi-bin/mailman/listinfo/devel
> >
> _______________________________________________
> Devel mailing list
> Devel at lists.geany.org
> https://lists.geany.org/cgi-bin/mailman/listinfo/devel
>



-- 
Best regards,
Volodymyr Kononenko
http://kononenko.ws
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.geany.org/pipermail/devel/attachments/20150309/4c0a9df6/attachment.html>