[Geany-Devel] pull request on GitHub, to add GeanyHighlightSelectedWords, into Geany Plugins

Steven Blatnick steve8track at xxxxx
Mon Jun 1 13:48:56 UTC 2015


Responses:

On 05/29/2015 07:21 PM, Colomban Wendling wrote:
> Le 29/05/2015 00:10, marius buzea a écrit :
>>    https://github.com/sblatnick/geany-plugins/blob/master/quick-search/src/quick-search.c.
>>
>> […]
>>
>> The quick-search.c calls Geany's search_find_text several times in one
>> processing, and each time a regex would be recompiled in search_find_text.
>> This is, I guess, a small cost when the regex is just a string.
Odd, I don't see this reply from Marius in my inbox.  Was this in 
private separately?
> search_find_text() doesn't do regex search when the flags don't ask for
> it, it only uses SCI_FINDTEXT().
>
> =====
>
> BTW, @Steven: search_find_text() is *NOT* part of the Geany plugin API
> and never have been.  The fact you can use it is a issue of the way
> Geany API was exported, and it is fixed in the dev version (meaning it
> won't work anymore).  Not also that this never worked on Windows.
Thanks for the information.  I wonder if any of my other plugins include 
non-API calls.  Is there an easy way to tell what is allowed and what 
shouldn't be?  Is there a reason we don't allow plugins to tie into 
anything when they could besides trying to stop plugins from being 
overtly complicated or breaking things?
>
> If you need the function, tell us and we can probably add it.  Though
> here all you need is SCI_FINDTEXT, that is already available through
> sicnitlla_send_commend(sci, SCI_FINDTEXT, flags, ttf).
Ok, I'll look into that.

Thanks,

Steve


More information about the Devel mailing list