[Geany-Devel] Linkage-Cleanup Build System Breakage

[Enrico Tröger]

On 09/11/14 17:57, Colomban Wendling wrote:
> Le 09/11/2014 16:15, Enrico Tröger a écrit :
>> On 29/10/14 16:17, Colomban Wendling wrote:
>>> [...]
>>>
>>> Enrico: would the change on geany_private.rc from
>>> https://github.com/b4n/geany/commit/a24d9217c3dfb959b4138fe3bffd871d9dc88ba4
>>> break Waf or something else?  (yes, I could check by running a VM, but I
>>> can also ask first :)
>>
>> I tested it on my VM and assumed it would break the build but
>> surprisingly it does not.
>> I don't know why but at least with Waf, using icons/geany.ico works as
>> well as ../icons/geany.ico. I cannot really explain it but your change
>> doesn't break the build.
> 
> Great then.  I also tried to build with Waf on Windows with this patch
> and it didn't complain.
> 
> So, I made a PR https://github.com/geany/geany/pull/377 please give it a
> quick look and tell me if you see anything absurd.  It should be OK
> though, as I successfully built a mostly-working executable with it :)

Sorry for the delay, I commented on the PR.


Regards,
Enrico

-- 
Get my GPG key from http://www.uvena.de/pub.asc

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: OpenPGP digital signature
URL: <http://lists.geany.org/pipermail/devel/attachments/20150118/d53f48d0/attachment.sig>