[Geany-Devel] [geany/geany] f03206: Windows: Compile geany_private.rc into Geany.exe for version data and icon

Enrico Tröger enrico.troeger at xxxxx
Sat Apr 25 10:20:49 UTC 2015

On 19/04/15 15:40, Enrico Tröger wrote:
> On 18/04/15 21:35, Matthew Brush wrote:
>> On 15-04-18 03:51 AM, Enrico Tröger wrote:
>>> On 18/04/15 11:47, Enrico Tröger wrote:
>>>> On 17/04/15 21:32, Colomban Wendling wrote:
>>>>> Le 12/04/2015 22:54, Enrico Tröger a écrit :
>>>>>> Branch:      refs/heads/master
>>>>>> Author:      Enrico Tröger <enrico.troeger at uvena.de>
>>>>>> Committer:   Enrico Tröger <enrico.troeger at uvena.de>
>>>>>> Date:        Sun, 12 Apr 2015 20:54:16 UTC
>>>>>> Commit:      f03206744361baac1c811db97f5d2816409d7787
>>>>>> https://github.com/geany/geany/commit/f03206744361baac1c811db97f5d2816409d7787
>>>>>> Log Message:
>>>>>> -----------
>>>>>> Windows: Compile geany_private.rc into Geany.exe for version data
>>>>>> and icon
>>>>> Should we integrate geany_private.rc in the library too?  This isn't
>>>>> done with Autotools, but could be added.
>>>> It's not really necessary. For Waf, I just added it to the binary where
>>>> it is necessary and kept it for the library.
>>>> The rc file serves two main purposes:
>>>> - add the icon to the binary
>>>> - add versioning information to the binary (e.g. in the file properties
>>>> dialog in the Details tab)
>>>> While especially the icon is important for the binary, I guess the rc
>>>> file is just nice to have for the library but not necessary.
>>>> But I agree we should do the same for Waf and autotools, either link it
>>>> or don't link it.
>>>> I don't mind which way to go.
>>> After thinking a bit more about this, I think we should not link the rc
>>> file against the library. We also don't link it against the plugin
>>> libraries.
>>> The rc file contains settings that the resulting binary is an executable
>>> and it includes also the geany.exe.manifest. Both do not apply to the
>>> library. So it is actually wrong to use that rc file for the library.
>>> If there are no objections, I will remove linking the rc file against
>>> the library in Waf.
>> None here.
>> I think the way it might make sense is if it contained artwork, UIs,
>> translations and stuff like they often do for Win32 API projects, and
>> that were actually used in libgeany.dll, but since we just use it for
>> the .exe icon, meta-info, styles, etc. I tend to agree it makes more
>> sense linked to the .exe.
>> We might still want an .rc file for the library though, if it's
>> important to show the correct meta-info in Windows explorer for the .dll
>> file (I dunno if it is?).
> I don't think so. The only benefit I see is that in the Windows explorer
> file properties dialog version information would appear. I don't know if
> Windows or any related software rely on this information or use it in
> any way.
> We also don't add this information to the plugin libraries and so why do
> it for geany.dll.

To finish this, I just removed linking the rc file against the library.


Get my GPG key from http://www.uvena.de/pub.asc

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: OpenPGP digital signature
URL: <http://lists.geany.org/pipermail/devel/attachments/20150425/77d410ab/attachment.sig>

More information about the Devel mailing list