[Geany-Devel] multiterm should be disabled if no valac is found

[Lex Trotman]

On 30 April 2014 22:40, Quentin Glidic <sardemff7+geany at sardemff7.net> wrote:
> On 2014-04-27 22:41, Matthew Brush wrote:
>>
>> On 14-04-27 01:08 PM, Colomban Wendling wrote:
>>>
>>> Le 27/04/2014 21:24, Matthew Brush a écrit :
>>>>
>>>> Yeah I guess AM_PROG_VALAC() just issues those warnings instead
>>>>
>>>> of failing as I'd have expected.
>>>>
>>>> In a perfect world, the generated *.[ch] files would be
>>>> distributed and when compiling (from tarball at least) no Vala
>>>> compiler would be required.
>
>
> GNOME folks just say that distributing generated files was a bad design
> idea.
>
>
>
>>> That's the very reason why the absence of valac doesn't trigger a
>>> failure (hence disabling the plugin): because tarballs include the
>>> C sources, and then valac isn't required unless you want to change
>>> the Vala source.
>>>
>>> I'm not sure what we can do here…  maybe magically detect it's not
>>> a tarball and then require valac?  Not sure.
>>>
>>
>> One not great option would be to check-in the generated source.
>
>
> Just require this little dependency that Vala is for everyone.
> Or consider that Git = non-tarball and do:
>
> if test -d .git -a -z "$VALAC"; then
> AC_MSG_ERROR([valac is required to build from Git])
> fi

The "proper" solution is for configure to test if valac is available,
then for the plugins that use it to decide if they need it (ie if they
need to make .c files) and to disable themselves if they need it and
its not available.  How they do that s/b up to the plugin, but a trial
make sounds good :)

Cheers
Lex


>
> --
>
> Quentin “Sardem FF7” Glidic
>
> _______________________________________________
> Devel mailing list
> Devel at lists.geany.org
> https://lists.geany.org/cgi-bin/mailman/listinfo/devel