[Geany-Devel] Code review for feature #683

[Steven VALSESIA]

> First, the "editor-notify" signal is a tight spot, all Scintilla
> events go there. Blocking them while saving may not be a good idea,
> especially considering that a file save error may display a modal
> dialog IIRC. You can do a plugin_idle_add(func) instead, and make
> func() return FALSE.

I think I don't understand, where do I block these signals ?
My implementation of editor-notify() return FALSE, so it doesn't block
anything, no ? :)

> Second, mentioning -lgthread-2.0 twice may be required, depending on
> the libraries and linker, and won't do any harm otherwise.

Ok, roger that !


2014-03-01 12:01 GMT+01:00 Dimitar Zhekov <dimitar.zhekov at gmail.com>:

> On Sat, 1 Mar 2014 11:28:13 +0100
> Steven VALSESIA <steven.valsesia at gmail.com> wrote:
>
> > Hi everybody !
>
> Hi.
>
> > Please, take a look to my patch concerning the feature request #683.
>
> A disclaimer first: I'm not using the autosave actions plugin.
> The code seems to match autosave closely, with no obvious errors.
>
> > Let me know if you see how I can improve my code :)
>
> First, the "editor-notify" signal is a tight spot, all Scintilla
> events go there. Blocking them while saving may not be a good idea,
> especially considering that a file save error may display a modal
> dialog IIRC. You can do a plugin_idle_add(func) instead, and make
> func() return FALSE.
>
> Second, mentioning -lgthread-2.0 twice may be required, depending on
> the libraries and linker, and won't do any harm otherwise.
>
> --
> E-gards: Jimmy
> _______________________________________________
> Devel mailing list
> Devel at lists.geany.org
> https://lists.geany.org/cgi-bin/mailman/listinfo/devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.geany.org/pipermail/devel/attachments/20140301/891c664e/attachment.html>