[Geany-Devel] Plugins Quality Check

[Lex Trotman]

Hi All,

On the off chance that we might be converging on a release I did a
compile of the plugins with the usual options (-Wall -Wextra
-Wno-unused-paratemers).

This was on GTK2 since many still don't work for GTK3.

The results are not too bad really :)

To summarise, other than deprecations which will be discussed below:

codenav - 2 unused variables
debugger - 1 warning, useless test, probably inconsequential
geanygendoc - 2 warnings, extra switch case may be consequential,
unused function
geanysendmail - 3 const discarded warnings
multiterm - unused variable warnings in code generated by the valac,
and const discarded warnings

Unused functions and variables are probably inconsequential, unless
they are the result of a typo in the code meant to use them, they need
a quick check and correct.

Extra switch case may indicate a typo, needs checking.

Discarded const potentially is a problem, it may indicate that
something may try to modify literal strings, which may have undefined
behaviour.  Sometimes library headers use char* when they should have
const char*, this is annoying, but it can usually be worked around.
But must be checked, including the ones generated by the Vala
compiler.

The details are at http://pastebin.geany.org/76dfx/

Since this is with GTK2 there are no GTK deprecation warnings (except
in Vala, which seems to have decided that the whole of GTK2 is
deprecated), but Glib ones are starting to creep through, in threading
mostly.  The problem with using the replacement functions is that
their existence depends on the version of glib on the target system,
not on the system Geany is compiled on.  Using the new functions may
therefore result in nasty surprises for users of binary packages.  Any
suggestions anyone?

Cheers
Lex