[Geany-Devel] [PATCH] Fix marker blinking by specifying of which indicator to clear

[Pavel Roschin]

> On 04/08/14 17:10, Pavel Roschin wrote:
> > ---
> >  spellcheck/src/gui.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/spellcheck/src/gui.c b/spellcheck/src/gui.c
> > index 5748e72..e05d5ce 100644
> > --- a/spellcheck/src/gui.c
> > +++ b/spellcheck/src/gui.c
> > @@ -404,7 +404,7 @@ static void indicator_clear_on_line(GeanyDocument *doc,
> > gint line_number) 
> >  	start_pos = sci_get_position_from_line(doc->editor->sci,
> > line_number); length = sci_get_line_length(doc->editor->sci, line_number);
> > -
> > +	sci_indicator_set(doc->editor->sci, GEANY_INDICATOR_ERROR);
> >  	sci_indicator_clear(doc->editor->sci, start_pos, length);
> >  }
> 
> Committed, thanks.
> 
> Just for my curiosity, how did you experience a marker "blinking"?
> I noticed while testing your patch that the "mark all occurences" marker
> got removed by indicator_clear_on_line() which is already enough to
> justify your change (in other words: oops :D).
> 
> I'm just curious what could cause a blinking.
> 
> Regards,
> Enrico
> 
> -- 
> Get my GPG key from http://www.uvena.de/pub.asc
> 


Hello, thanks for accepting.

I tested it with new Automark plugin (recently merged in GP master). Automark is
similar to "mark all occurrences" marker but it sets marker automatically with
150 ms delay. Whenever spellchecker removes marker (e.g. when you type a char),
it triggers automark to mark this word again - and battle of those two plugins
causes "blinking".

--
Best regards,
Pavel Roschin aka RPG