[Geany-Devel] multiterm should be disabled if no valac is found

[Matthew Brush]

On 14-04-27 01:08 PM, Colomban Wendling wrote:
> Le 27/04/2014 21:24, Matthew Brush a écrit :
>> On 14-04-27 05:39 AM, Dimitar Zhekov wrote:
>>> $ ./autogen.sh
>>> ...
>>> checking for valac... valac
>>> configure: WARNING: no proper vala compiler found
>>> configure: WARNING: you will not be able to compile vala source files
>>> ...
>>> Plugins:
>>> MultiTerm: yes
>>>
>>> $ make
>>> ...
>>> make[3]: Entering directory
>>> `/home/build/projects/plugins/testing/multiterm/src'
>>> VALAC multiterm_la_vala.stamp
>>> /bin/bash: valac: command not found
>>> make[3]: *** [multiterm_la_vala.stamp] Error 127
>>>
>>> I fetched a clean git, just to be sure there's no some older
>>> configuration left.
>>>
>>
>> Yeah I guess AM_PROG_VALAC() just issues those warnings instead of
>> failing as I'd have expected.
>>
>> In a perfect world, the generated *.[ch] files would be distributed and
>> when compiling (from tarball at least) no Vala compiler would be required.
>
> That's the very reason why the absence of valac doesn't trigger a
> failure (hence disabling the plugin): because tarballs include the C
> sources, and then valac isn't required unless you want to change the
> Vala source.
>
> I'm not sure what we can do here…  maybe magically detect it's not a
> tarball and then require valac?  Not sure.
>

One not great option would be to check-in the generated source.

Cheers,
Matthew Brush