[Geany-Devel] [Geany-Plugins] [PATCH] GTK3 support for GeanyPrj

[Colomban Wendling]

Le 18/03/2013 15:23, יוסף אור בוצ'קו a écrit :
> 
> Attachment: [PATCH] GTK3 support for GeanyPrj

I'd like the maintainer to give this a look before applying it against
his will.  I CC'd him.

Regards,
Colomban

Quick review below:

> From 3962af76307290ba5f6210cc74f23239b92cd96f Mon Sep 17 00:00:00 2001
> From: Yosef Or Boczko <yosefor3 at walla.com>
> Date: Mon, 18 Mar 2013 14:55:06 +0200
> Subject: [PATCH] GTK3 support for GeanyPrj
> 
> ---
>  build/geanyprj.m4   | 6 +++++-
>  geanyprj/src/menu.c | 4 ++--
>  2 files changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/build/geanyprj.m4 b/build/geanyprj.m4
> index 4c11ab4..528ba8d 100644
> --- a/build/geanyprj.m4
> +++ b/build/geanyprj.m4
> @@ -1,8 +1,12 @@
>  AC_DEFUN([GP_CHECK_GEANYPRJ],
>  [
>      GP_ARG_DISABLE([GeanyPrj], [auto])
> -    GP_CHECK_PLUGIN_GTK2_ONLY([GeanyPrj])
> +    
> +    GP_CHECK_PLUGIN_DEPS([GeanyPrj], [GEANYPRJ],
> +                         [$GP_GTK_PACKAGE >= 2.16])
> +    

No need to explicitly check for GTK here, just remove the
GP_CHECK_PLUGIN_GTK2_ONLY() call.

>      GP_COMMIT_PLUGIN_STATUS([GeanyPrj])
> +    
>      AC_CONFIG_FILES([
>          geanyprj/Makefile
>          geanyprj/src/Makefile
> diff --git a/geanyprj/src/menu.c b/geanyprj/src/menu.c
> index 42cc61e..08fb389 100644
> --- a/geanyprj/src/menu.c
> +++ b/geanyprj/src/menu.c
> @@ -180,9 +180,9 @@ static PropertyDialogElements *build_properties_dialog(gboolean properties)
>  	label = gtk_label_new(_("Type:"));
>  	gtk_misc_set_alignment(GTK_MISC(label), 1, 0);
>  
> -	e->type = gtk_combo_box_new_text();
> +	e->type = gtk_combo_box_text_new();
>  	for (i = 0; i < NEW_PROJECT_TYPE_SIZE; i++)
> -		gtk_combo_box_append_text(GTK_COMBO_BOX(e->type), project_type_string[i]);
> +		gtk_combo_box_text_append_text(GTK_COMBO_BOX(e->type), project_type_string[i]);

Cast should be GTK_COMBO_BOX_TEXT().

>  	gtk_combo_box_set_active(GTK_COMBO_BOX(e->type), 0);
>  
>  	ui_table_add_row(GTK_TABLE(table), 4, label, e->type, NULL);
> -- 1.8.2