[Geany-Devel] [PATCH] configure.ac remove additional c++ test

[Lex Trotman]

Hi Andreas,

On 21 February 2013 19:46, Andreas Müller <schnitzeltony at googlemail.com> wrote:
> For openembedded cross-builds CXX can contain something like:
>
> arm-oe-linux-gnueabi-g++  -march=armv5te  -marm -mthumb-interwork --sysroot=/home/jenkins/oe/shr-core-branches/shr-core/tmp-eglibc/sysroots/qemuarm
>
> This ends up in
>
> configure:5582: error: No C++ compiler found. Please install a C++ compiler.
>
> Anyway if [1] is still valid, the combination of AC_PROG_CC and AC_PROG_CXX
> should thow an error message.

Geany *requires* both a C compiler and a C++ compiler, so both must be
tested for.  The test you have removed is to get around the stupid
behavior of AC_PROG_CXX of returning g++ if it finds g++ or if it
finds nothing.  Perhaps which should only be run if CXX == g++.

I presume you are setting CXX on the configure line to the whole line
you specified above.  Try setting CXX to the executable only and
CXXFLAGS to the rest.

Cheers
Lex

>
> [1] http://lists.gnu.org/archive/html/bug-autoconf/2010-05/msg00001.html
>
> Signed-off-by: Andreas Müller <schnitzeltony at googlemail.com>
> ---
>  configure.ac |    5 -----
>  1 files changed, 0 insertions(+), 5 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index c37312a..742bf35 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -26,11 +26,6 @@ AC_USE_SYSTEM_EXTENSIONS
>  AC_PROG_CC
>
>  AC_PROG_CXX
> -# check for C++ compiler explicitly and fail if none is found, do this check
> -# after AC_PROG_CXX has set the CXX environment variable
> -if ! which $CXX >/dev/null 2>&1; then
> -       AC_MSG_ERROR([No C++ compiler found. Please install a C++ compiler.])
> -fi
>
>  AC_PROG_INSTALL
>  AC_PROG_LN_S
> --
> 1.7.6.5
>
> _______________________________________________
> Devel mailing list
> Devel at lists.geany.org
> https://lists.geany.org/cgi-bin/mailman/listinfo/devel