[Geany-Devel] Gaeny-plugins: Some minor changes to silence warnings

[Lex Trotman]

Additional patch to treebrowser.c make sure every path leading to a
g_free has a g_strdup(), oops.

Note I am only using the HACKING approved "-Wall -Wextra -O2
-Wno-unused-parameter" not the full War and Peace novel of options
that Colomban uses :)

Cheers
Lex

On 20 February 2013 00:31, Colomban Wendling <lists.ban at herbesfolles.org> wrote:
> Le 19/02/2013 13:22, Frank Lanitz a écrit :
>> Am 17.02.2013 04:09, schrieb Lex Trotman:
>>> Attached is a patch containing a few obvious fixes for warnings in the
>>> plugins, mostly adding consts, gpointer casts and unsigned int loop
>>> counters.
>>>
>>> The only one that is likely to have been bad (tm) is in treebrowser.c
>>> it g_freed a static string.  Setting the string const found that.
>>>
>>> treebrowser.c still has warnings about two unused variables, since in
>>> each case some work is done to set them, the treebrowser maintainer
>>> should look and see if they are meant to be used somewhere, or remove
>>> them and the setting code.
>>
>> I had a short look and think we can apply it. At least I didn't see
>> anything which is likely to fail.
>
> I didn't test it, but agree that the diff looks fine.
>
> Cheers,
> Colomban
> _______________________________________________
> Devel mailing list
> Devel at lists.geany.org
> https://lists.geany.org/cgi-bin/mailman/listinfo/devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: warning2.patch
Type: application/octet-stream
Size: 707 bytes
Desc: not available
URL: <http://lists.geany.org/pipermail/devel/attachments/20130220/e8906bde/attachment.obj>