[Geany-Devel] GTK 2.16 build error in Markdown plugin

[Matthew Brush]

On 13-01-31 10:17 AM, Colomban Wendling wrote:
> Le 31/01/2013 19:09, Enrico Tröger a écrit :
>> Hey Matthew,
>>
>> the Markdown plugin currently does not compile on GTK 2.16, more
>> specific with GLib < 2.26.
>> See http://nightly.geany.org/misc/build_gtk216_plugins_stderr.log for
>> details.
>>
>> One issue is that "uint" (conf.c:245) is not defined. I guess this is
>> just a typo and should be "guint". I just don't understand why this
>> works on other systems, like the nightly build environment for
>> ArchLinux. Anyway, changing it to "guint" is probably good enough.
>
> I guess the newer GTK include a system header that defines the uint type
> or something like this.
>
> Also Matthew, markdown_config_get_uint_key() have a default_value
> argument (the one with type uint), but the default used is hard-coded as
> 12, it doesn't look so legitimate ;)
>

Hehehe. I think that was a copy and paste error from a function that 
returned a default font size of 12pt for config file key, in case you 
were curious :) Fixed.

>> Though there is another issue:
>> g_object_class_install_properties is first available in GLib 2.26 (used
>> in conf.c:372). So maybe this plugin needs a higher GLib requirement.
>
> Or simply not use this function, or emulate it.  I think it's easy
> enough not to use the cheap and mean solution of higher dep for this.
>

Agreed. I made a little wrapper function to do it.

Cheers,
Matthew Brush