[Geany-Devel] [PATCH geany-plugins 02/10] insertnum: Fix GTK+3 support
Matthew Brush
mbrush at xxxxx
Sat Apr 6 20:31:50 UTC 2013
On 14-04-06 05:04 AM, Dimitar Zhekov wrote:
> [...]
> Anyway, I was too categorical. The old hack of #defining GTK_COMPAT_H
> before including geanyplugin.h, and manually writing any compatibility
> code, will probably work fine with all Geany versions. That'll look a
> bit ugly, and IMHO, letting the plugins decide whether to include
> "gtkcompat.h" would be better...
>
I agree, gtkcompat.h should be optional, to be included explicitly only
if a plugin needs/wants it. It does seem wrong to prevent plugins from
targeting older versions of Geany from when this header didn't exist or
forcing their min GTK+ to 2.24.
If we keep gtkcompat.h forced into all plugins maybe we should document
the trick of blocking it out by predefining the guard macro like that.
Cheers,
Matthew Brush
More information about the Devel
mailing list