[Geany-Devel] [PATCH geany-plugins 02/10] insertnum: Fix GTK+3 support

[Matthew Brush]

On 14-04-05 11:40 AM, Dimitar Zhekov wrote:
> On Fri,  5 Apr 2013 08:58:21 +0200
> Quentin Glidic <sardemff7+geany at sardemff7.net> wrote:
>
>>   geanyinsertnum/src/insertnum.c | 4 ++--
>> -	GTK_WIDGET_SET_FLAGS(button, GTK_CAN_DEFAULT);
>> +	gtk_widget_set_can_default(button, TRUE);
>
>>   geanyinsertnum/src/insertnum.c | 14 +++++++-------
>> -	combo = GTK_COMBO_BOX(gtk_combo_box_entry_new_text());
>> +	combo = GTK_COMBO_BOX(gtk_combo_box_text_new_with_entry());
>> -	gtk_combo_box_append_text(combo, "2");
>> +	gtk_combo_box_text_append_text(GTK_COMBO_BOX_TEXT(combo), "2");
>> ...
>
> Thank you, Quentin, but...
>
> Using gtkcompat requires either Geany >= 20130818 or gtk+ >= 2.24.
> Since I care more about the backwards compatibility than for gtk+3,
> my plans are to update insertnum when gtkcompat becomes part of geany-
> plugins, or when we increase the gtk+ requirements of Geany to gtk+ >=
> 2.24, or after 2 years - whichever comes first.
>
> To the lead developer who reviews the gtkcompat patches: please do not
> apply the ones for insertnum.
>

Hi,

Rather than breaking compat with older Geany or preventing GTK3 users 
from using the plugin, you could just add the 2 #if's needed to make the 
plugin build with GTK3 for now.

My $0.02

Cheers,
Matthew Brush