[Geany-Devel] [PATCH geany-plugins 02/10] insertnum: Fix GTK+3 support

[Lex Trotman]

Hi Dimitar,


On 6 April 2014 04:40, Dimitar Zhekov <dimitar.zhekov at gmail.com> wrote:

> On Fri,  5 Apr 2013 08:58:21 +0200
> Quentin Glidic <sardemff7+geany at sardemff7.net> wrote:
>
> >  geanyinsertnum/src/insertnum.c | 4 ++--
> > -     GTK_WIDGET_SET_FLAGS(button, GTK_CAN_DEFAULT);
> > +     gtk_widget_set_can_default(button, TRUE);
>
> >  geanyinsertnum/src/insertnum.c | 14 +++++++-------
> > -     combo = GTK_COMBO_BOX(gtk_combo_box_entry_new_text());
> > +     combo = GTK_COMBO_BOX(gtk_combo_box_text_new_with_entry());
> > -     gtk_combo_box_append_text(combo, "2");
> > +     gtk_combo_box_text_append_text(GTK_COMBO_BOX_TEXT(combo), "2");
> > ...
>
> Thank you, Quentin, but...
>
> Using gtkcompat requires either Geany >= 20130818 or gtk+ >= 2.24.
>

I'm not sure I understand your Geany version number, is it a future date,
and if so why 18 Aug?

Gtkcompat is supposed to handle compatibility for GTK back to 2.16 IIUC,
 If it doesn't thats a bug :).  Geany's GTK minimum requirement hasn't been
increased from 2.16 but it now also can be built with gtk3.  The intention
is to encourage plugins to do the same.  We are not losing support for gtk2.



> Since I care more about the backwards compatibility than for gtk+3,
> my plans are to update insertnum when gtkcompat becomes part of geany-
> plugins,


I guess it isn't clearly explained, gtkcompat.h is part of Geany, not the
plugins, but they can use it since its only a header file.  Its in Geany's
Git.  It doesn't become part of geany plugins.



> or when we increase the gtk+ requirements of Geany to gtk+ >=
> 2.24, or after 2 years - whichever comes first.
>

Not sure why you want gtk 2.24? Anyway its your choice of course, user
complaints that it doesn't work with gtk3 will be pointed to you :)

Cheers
Lex


>
> To the lead developer who reviews the gtkcompat patches: please do not
> apply the ones for insertnum.
>
> --
> E-gards: Jimmy
> _______________________________________________
> Devel mailing list
> Devel at lists.geany.org
> https://lists.geany.org/cgi-bin/mailman/listinfo/devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.geany.org/pipermail/devel/attachments/20130406/48d58ab6/attachment.html>