[Geany-Devel] [PATCH geany-plugins 02/10] insertnum: Fix GTK+3 support

Dimitar Zhekov dimitar.zhekov at xxxxx
Fri Apr 5 18:39:49 UTC 2013


On Fri,  5 Apr 2013 08:58:21 +0200
Quentin Glidic <sardemff7+geany at sardemff7.net> wrote:

>  geanyinsertnum/src/insertnum.c | 4 ++--
> -	GTK_WIDGET_SET_FLAGS(button, GTK_CAN_DEFAULT);
> +	gtk_widget_set_can_default(button, TRUE);

>  geanyinsertnum/src/insertnum.c | 14 +++++++-------
> -	combo = GTK_COMBO_BOX(gtk_combo_box_entry_new_text());
> +	combo = GTK_COMBO_BOX(gtk_combo_box_text_new_with_entry());
> -	gtk_combo_box_append_text(combo, "2");
> +	gtk_combo_box_text_append_text(GTK_COMBO_BOX_TEXT(combo), "2");
> ...

Thank you, Quentin, but...

Using gtkcompat requires either Geany >= 20130818 or gtk+ >= 2.24.
Since I care more about the backwards compatibility than for gtk+3,
my plans are to update insertnum when gtkcompat becomes part of geany-
plugins, or when we increase the gtk+ requirements of Geany to gtk+ >=
2.24, or after 2 years - whichever comes first.

To the lead developer who reviews the gtkcompat patches: please do not
apply the ones for insertnum.

-- 
E-gards: Jimmy


More information about the Devel mailing list