[Geany-Devel] Fwd: [geany/geany] a3664f: Fix spawning [synchronous] commands on Windows

[Nick Treleaven]

Hi all,
I've replaced the command spawning code on Windows as there were serious 
issues with it (see below). I've been using my replacement build for a 
month and haven't found any problems.

This mainly affects build commands on Windows. If you use Windows, 
please test it.


-------- Original Message --------
Branch:      refs/heads/master
Author:      Nick Treleaven <nick.treleaven at btinternet.com>
Committer:   Nick Treleaven <nick.treleaven at btinternet.com>
Date:        Wed, 24 Oct 2012 16:35:19
Commit:      a3664fae9ece396952d732cc937e63192d8c6f76
 
https://github.com/geany/geany/commit/a3664fae9ece396952d732cc937e63192d8c6f76

Log Message:
-----------
Fix spawning [synchronous] commands on Windows

Build command spawning failed sometimes when there were several
pages of errors. In these cases the process would block for 30s and
then abort. (Some hangs were also experienced).

This fix does cause a console window to be shown for the duration of
the spawned process. This seems acceptable compared with the old
broken behaviour, and can be useful to abort the build command by
closing the console window.

Note: If 'env' is passed, the old broken spawning is used.