[Geany-Devel] [Geany-devel] Separating session file lists from config (again)

[Lex Trotman]

On 10 October 2012 06:58, Dimitar Zhekov <dimitar.zhekov at gmail.com> wrote:

> On Thu, 4 Oct 2012 10:51:29 +1000
> Lex Trotman <elextr at gmail.com> wrote:
>
> > > > Are all settings saved on apply? not just the prefs/project prefs
> ones?
> > >
> > > Edit -> Preferences -> OK|Apply saves the entire geany.conf:
> > > dialog preferences, UI settings and file list.
> > >
> > > Project -> Properties -> OK saves the entire $project.conf: project
> > > settings and file list.
> > >
> > > File -> Quit does both.
> > >
> >
> > AFAICT build->set build commands->ok does neither, it assumes save at the
> > end, thats the problem, and why the save on quit is still needed and why
> > failing to save on shutdown is a breakage.
>
> Unless you are looking at some really old sources,


Oh dear it is *yesterdays* git :)


> a project-less
> build -> set build commands -> ok saves the changes under filedefs/
> immediately ("save filetypes now" in the mailing list). Just fill some
> commands, OK, and grep ~/.config/geany.
>

It doesn't save the config file though, so no non-filetype settings saved.


>
> Save on Quit is needed for the interface preferences, such as View ->
> Show Sidebar, and the project-less file list. Unfortunately, the file
> list is saved even with a project open, but attempts to fix it trigger
> a "multiply instances" discussion.
>

Yes, Geany does *not* do multiple instances properly, therefore being
ignored for now.  If you do multiple instances with the same project or
config file it will break (ie not do what you wanted), its just a matter of
when.


>
> > The build one is the one I know, my question is then what other dialogs
> or
> > menu items etc change settings but fail to cause a save because they
> still
> > assume save on exit?
>
> The ones from save_ui_prefs(). You can't reasonably expect a file save
> each time the side bar is shown/hidden, or the main window is
> moved/sized...
>

1. why not?
2. which is why they should be in the session file not the prefs file,
also, to me, if I arranged windows to fit what I was looking at, it would
be good it that was restored with the project session as well.


>
> > > Saving dialog preferences and project settings on Quit does not make
> > > real sense, but it's the same file, so there is no reason to separate
> > > them. Yet they are internally separate (static) functions, see
> > > keyfile.c:configuration_save() and project.c:write_config().
> > >
> >
> > Not sure what you mean by "its the same file", its not the same file and
> > doesn't have the same contents?
>
> The dialog preferences are in the same file (geany.conf) as UI settings
> and the project-less file list, which need save on quit; and the project
> properties are in the same file ($project.geany) as the project file
> list, which needs save on quit. So (not) saving the formers does not
> make real difference, the entire file must be re-written anyway.
>

Yeah, which is why I want to split 'em

Cheers
Lex


>
> --
> E-gards: Jimmy
> _______________________________________________
> Devel mailing list
> Devel at lists.geany.org
> https://lists.geany.org/cgi-bin/mailman/listinfo/devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.geany.org/pipermail/devel/attachments/20121010/c8468a0c/attachment.html>