[Geany-Devel] [Geany-devel] [PATCH 13/19] Remove the "set" button from the project properties dialog

Colomban Wendling lists.ban at herbesfolles.org
Mon Oct 8 15:11:25 UTC 2012


Le 06/10/2012 19:39, Nick Treleaven a écrit :
> On 06/10/2012 17:25, Colomban Wendling wrote:
>> Hi,
>>
>> This got committed, but actually the button did set "%p" (not %d) to the
>> directory in which execute non-filetype commands (like make).  This is
> 
> I was aware that it sets %p, not %d.

OK, fine then;  I wanted to check it wasn't a mistake since Jiří's
original patch talked about %d.

>> useful for anybody with a basedir-only build system (non-recursive
>> autotools, handmade Makefiles, Waf, plenty of others), so I think
>> providing an easy way to set this is useful.
>>
>> Commit is 9add067c040b23753d982688eb19fee932437301
>>
>> What do you think?
> 
> I had 2 reasons to remove it:
> 
> * It's bad UI design to have a button on one notebook page that silently
> affects fields on another notebook page.

Agreed, UI wasn't great.

> * It's quite easy to type %p, select it and middle-click paste it to any
> other fields desired.

OK, fair enough.

> I'm not against adding something like it, so long as it's on the Build
> page.

Well, maybe we don't need any UI, as you said it's not hard to manually
set.  However, perhaps we should make it easier to discover the feature,
or suggest user to use it, maybe ad a hint in the manual.  I just think
that it's a common enough use case to do something for "suggest" the way
to go.

Regards,
Colomban


More information about the Devel mailing list