[Geany-devel] [geany/geany] Question on - 7b3b65: Add workaround for users with an invisible selection style

[Lex Trotman]

On 4 June 2012 03:04, Nick Treleaven <git-noreply at geany.org> wrote:
> Branch:      refs/heads/master
> Author:      Nick Treleaven <nick.treleaven at btinternet.com>
> Committer:   Nick Treleaven <nick.treleaven at btinternet.com>
> Date:        Sun, 03 Jun 2012 17:04:03
> Commit:      7b3b65e27df77be862714e2de69aa9f61764a91b
>             https://github.com/geany/geany/commit/7b3b65e27df77be862714e2de69aa9f61764a91b
>
> Log Message:
> -----------
> Add workaround for users with an invisible selection style
>
> This is likely to be the case for any users that copied the system
> selection style line as this was incorrectly set before, but not
> applied.
>

Hi Nick,

Based on your answer on my ML question is this necessary?

Now that we always apply the settings, a selection style of
false,false will reset to the Scintilla default "The default is to
show the selection by changing the background to light gray and
leaving the foreground the same as when it was not selected".  So
false, false shouldn't be invisible.

Of course it might be invisible on particular backgrounds, but so might c0c0c0.

Or have I still misunderstood something?

Cheers
Lex

>
> Modified Paths:
> --------------
>    src/highlighting.c
>
> Modified: src/highlighting.c
> 6 files changed, 6 insertions(+), 0 deletions(-)
> ===================================================================
> @@ -790,6 +790,12 @@ static void styleset_common(ScintillaObject *sci, guint ft_id)
>        sci_set_property(sci, "fold.at.else", "1");
>
>        style = &common_style_set.styling[GCS_SELECTION];
> +       if (!style->bold && !style->italic)
> +       {
> +               g_warning("selection style is set to invisible - ignoring!");
> +               style->italic = TRUE;
> +               style->background = 0xc0c0c0;
> +       }
>        /* bold (3rd argument) is whether to override default foreground selection */
>        SSM(sci, SCI_SETSELFORE, style->bold, invert(style->foreground));
>        /* italic (4th argument) is whether to override default background selection */
>
>
> @@ Diff output truncated at 100000 characters. @@
>
>
> --------------
> This E-Mail was brought to you by github_commit_mail.py (Source: TBD).
> _______________________________________________
> Geany-commits mailing list
> Geany-commits at uvena.de
> https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-commits