[Geany-devel] Selection and colour schemes

Lex Trotman elextr at xxxxx
Sat Jun 2 06:27:15 UTC 2012


Hi All,

I just pushed a "fix" for switching colour schemes from say dark to
default leaving selection unchanged.

But in reality the code at highlighting.c doesn't actually do what it
advertises, the comment says "to override default" which matches the
documentation, but in fact what the code does is "to change from what
is currently set".  Of course if you are changing from default to
another colour scheme thats ok, but if you are changing from a colour
scheme that has changed this setting then what is set won't be
default.

I think the code should be:
if (common_style_set.styling[GCS_SELECTION].bold)
    SSM(sci, SCI_SETSELFORE, etc...
else
    SSM(sci, SCI_SETSELFORE, whatever the default is)

but I can't find where to get the real default value and have run out of time.

Any thoughts or suggestions?

Cheers
Lex



More information about the Devel mailing list