[Geany-Devel] Document Message/File Monitoring Behaviour (was Re: Bug: Conflicting Keyboard shortcut in "reload file" dialog - ID: 3587465)

[Nick Treleaven]

On 03/12/2012 14:18, Colomban Wendling wrote:
> Le 03/12/2012 14:35, Nick Treleaven a écrit :
>> On 01/12/2012 06:16, Matthew Brush wrote:
>>> I also made a mockup for "deleted/moved on disk" infobar. I'll put a
>>> link to avoid spamming the list:
>>
>> Thanks for doing the mockups. Infobars probably would be better than the
>> status quo, but I think both of the mockups are too complicated. There
>> are too many options IMO.
>>
>> I'm not sure if 'Close all externally modified files' is worth having
>> and is a safe workflow, certainly it shouldn't include modified documents.
>
> Agreed.  I'm not sure it's useful, at least as-is.  If we have "close
> all others", why not "reload all others"?  And I'm really not sure it
> makes sense to suppose that one wants to perform the same action on all
> files matching the "externally modified" criteria.

Exactly, usually I want to reload some and close the others.

>> I don't think we need a Close button. Closing the document can be done
>> in the normal way. Or were you planning on disabling normal closing?
>> That would complicate the UI code.
>
> IIUC, the idea was that closing the document "the normal way" would ask
> again if the user didn't make a choice yet.  And although it might
> indeed look duplicate, I think it's important to make it a clearly
> visible option as an answer to the question.  It being a button or
> something else I don't have an opinion yet.

OK. Presumably 'normal' save or reload would also ask the user for 
confirmation. Are there any other use cases like these, maybe from plugins?

BTW should we make a release before these changes? Especially if coupled 
with the file-monitor instead of disk poll change, I think this will 
need time to stabilize. Perhaps we should delay this to 1.24?

>>> Mockup for "document changed on disk":
>>> http://codebrainz.ca/images/infobar-mockup.png
>>>
>>> Mockup for "document deleted (or moved) on disk":
>>> http://codebrainz.ca/images/infobar-mockup-deleted.png
>>
>> I'm not sure that 'Save as' is needed, the user can use 'File->Save As'
>> if needed. (Resave is a good option though).
>
> Agreed.  Or simply have only "save" (or similar) that triggers a
> pre-filled save as dialog, so one could just hit "save" in it to save
> under the same name.  This would (IMO) fill both use-cases of save and
> save as, and having to agree on the file name on such a case doesn't
> look like a big issue to me.

+1

> Also, as I discussed a bit on IRC (without much success though :D), I'm
> not completely sure if the "dismiss" button (we agreed this probably
> wasn't the best name for it BTW) is useful: I personally don't really
> see why somebody would like to hide the warning while not making a
> decision on what to do with the file.
> Though, that's no big deal.

Agree, we probably shouldn't allow 'Dismiss'.