[Geany-devel] geany-plugins: Autotools usage
sardemff7+geany at xxxxx
Sun Apr 22 16:55:16 UTC 2012
On 22/04/2012 18:21, Chow Loong Jin wrote:
> On 22/04/2012 20:09, Quentin Glidic wrote:
>> I noticed a global misuse / misunderstanding of the Autotools
>> (mostly about the dist mechanism) among the geany-plugins.
> Could you elaborate, please?
> I noticed that you have shifted all the ENABLE_$PLUGIN conditionals
> to the top-level Makefile.am instead, by modifying the SUBDIRS
> variable there. However, this is not desirable as disabled plugins
> will be excluded from the release tarball generated by `make dist'.
> --enable/disable-$plugin should only toggle the building of the
> actual plugin.
That’s exactly the misunderstanding I was speaking about. From the
“If SUBDIRS is defined conditionally using Automake conditionals,
Automake will define DIST_SUBDIRS automatically from the possible values
of SUBDIRS in all conditions.”
And here’s the diff of the "tar tf" on the make dist tarball:
--- before-patch 2012-04-22 18:33:34.080440186 +0200
+++ after-patch 2012-04-22 18:33:48.168440399 +0200
@@ -127,0 +128 @@
@@ -201,0 +203 @@
@@ -219,0 +222 @@
@@ -243,0 +247 @@
@@ -310,0 +315 @@
@@ -367,0 +373 @@
@@ -695,0 +702 @@
@@ -749,0 +757 @@
@@ -914,0 +923 @@
@@ -934,0 +944 @@
Automake handles the conditionnal perfectly by itself, and just need
some "dist_" prefixes here and there, while EXTRA_DIST should be
reserved for files that are used outside of automake scope.
Quentin "Sardem FF7" Glidic
More information about the Devel