[Geany-devel] Various pref changes not ignored on dialog cancel

Nick Treleaven nick.treleaven at xxxxx
Fri Sep 16 10:33:31 UTC 2011

--- On Thu, 15/9/11, Colomban Wendling <lists.ban at herbesfolles.org> wrote:

> > How about adding a PREF_CANCEL action to prefs.c only
> that will call a
> > stash_group_cancel() to reset the values? The other

I don't think that's a good design, the stash group settings should not actually be changed until ok/apply.

Perhaps you meant stash_tree_cancel(), but see below.

> option is to clear
> > the store, but that means recreating the various list
> [a visibly slow
> > process] each time Edit -> Preferences is invoked,
> while traversing the
> > model is fast.
> What about traversing the model on reshow to reset it to
> the default
> values?

Yes, that would be best. (This would be similar to how all stash prefs work with stash_group_display - the widgets are updated with the current settings).

> (though honestly building the view don't seem
> any slow to me)

I didn't notice any slowness, but it would be interesting to know why if it is.


More information about the Devel mailing list