[Geany-devel] Various pref changes not ignored on dialog cancel

Colomban Wendling lists.ban at xxxxx
Thu Sep 15 20:48:06 UTC 2011

Le 15/09/2011 19:59, Dimitar Zhekov a écrit :
> On Thu, 15 Sep 2011 17:45:25 +0100 (BST)
> Nick Treleaven <nick.treleaven at btopenworld.com> wrote:
>> I've found a bug when changing a various pref setting in the prefs
>> dialog, then cancelling the dialog without applying the changes.
>> Next time the dialog is shown the edited values are still present.
> You are right, the problem is that cancelling will not reset the
> internal stash tree values (the spin renderer is an unrelated bug).

Ah right, good catch.

> How about adding a PREF_CANCEL action to prefs.c only that will call a
> stash_group_cancel() to reset the values? The other option is to clear
> the store, but that means recreating the various list [a visibly slow
> process] each time Edit -> Preferences is invoked, while traversing the
> model is fast.

What about traversing the model on reshow to reset it to the default
values?  (though honestly building the view don't seem any slow to me)

More information about the Devel mailing list