[Geany-devel] Various pref changes not ignored on dialog cancel

Dimitar Zhekov dimitar.zhekov at xxxxx
Thu Sep 15 17:59:35 UTC 2011

On Thu, 15 Sep 2011 17:45:25 +0100 (BST)
Nick Treleaven <nick.treleaven at btopenworld.com> wrote:

> I've found a bug when changing a various pref setting in the prefs
> dialog, then cancelling the dialog without applying the changes.
> Next time the dialog is shown the edited values are still present.

You are right, the problem is that cancelling will not reset the
internal stash tree values (the spin renderer is an unrelated bug).

How about adding a PREF_CANCEL action to prefs.c only that will call a
stash_group_cancel() to reset the values? The other option is to clear
the store, but that means recreating the various list [a visibly slow
process] each time Edit -> Preferences is invoked, while traversing the
model is fast.

E-gards: Jimmy

More information about the Devel mailing list