[Geany-devel] [Geany] hide menu bar on full-screen
pedro at xxxxx
Sat Oct 22 23:18:34 UTC 2011
Of course I can give a hand! But wouldn't be dangerous hide menu bar in
normal view? I think some people could get stuck after that! It has happened
with amarok some years ago until developers remove the functionality.
On Sat, Oct 22, 2011 at 11:38 PM, Matthew Brush <mbrush at codebrainz.ca>wrote:
> Is there any chance we could not commit this since I'll have to re-convert
> the old Glade 2 file to Glade 3/GtkBuilder again? Once the switch is
> complete I can hand-port the changes here.
> I hate to cause extra effort since we appreciate when people can help out
> but would it be possible for you to post this to the patch tracker so
> that it doesn't get lost?
> Also, it would be cool to generally add options to show/hide the menu bar
> and the status bar, whether in fullscreen or not. There's already a feature
> request about the status bar.
> Matthew Brush
>  https://sourceforge.net/**tracker/?group_id=153444&atid=**787793<https://sourceforge.net/tracker/?group_id=153444&atid=787793>
>  https://sourceforge.net/**tracker/index.php?func=detail&**
> On 11-10-22 03:19 PM, Pedro Cirne wrote:
>> "& ui_prefs.fullscreen" was redundant, state brings "ui_prefs.fullscreen
>> & interface_prefs.hide_menubar_**on_fullscreen" from caller. Now with
>> tabs..I think it's ok!
>> On Sat, Oct 22, 2011 at 6:03 PM, Dimitar Zhekov
>> <dimitar.zhekov at gmail.com <mailto:dimitar.zhekov at gmail.**com<dimitar.zhekov at gmail.com>>>
>> On Thu, 20 Oct 2011 12:43:15 +0100
>> Pedro Cirne <pedro at cirne100.eu <mailto:pedro at cirne100.eu>> wrote:
>> > Here it is...I hope it's useful!
>> > On Thu, Oct 20, 2011 at 1:55 AM, Lex Trotman <elextr at gmail.com
>> <mailto:elextr at gmail.com>> wrote:
>> > > On 20 October 2011 11:39, Pedro Cirne <pedro at cirne100.eu
>> <mailto:pedro at cirne100.eu>> wrote:
>> > > > I have edited the source code to make it works for me, is it
>> useful for
>> > > the
>> > > > project?
>> > >
>> > > If you submit a patch/pull request we will certainly have a look
>> > > it. Then you may not have to keep applying it each time Geany
>> > > upgrades.
>> Looks fine to me, except that some of the changes are indented with
>> spaces instead of tabs.
>> I'm not quite sure why ui_menubar_showhide() should take a gboolean
>> state, check it with & and hide the menu for state = 1 (or TRUE?). It
>> may be the most effective way, but writing an extra line or too to make
>> the code stupid and simple may be a good idea.
>> A good thing to have, though I personnaly am not going to use it.
>> E-gards: Jimmy
>> Geany mailing list
>> Geany at uvena.de <mailto:Geany at uvena.de>
>> Geany mailing list
>> Geany at uvena.de
> Geany mailing list
> Geany at uvena.de
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Devel