[Geany-devel] Speed up & simplify stash tree display/update

[Nick Treleaven]

On 18/10/2011 18:31, Dimitar Zhekov wrote:
> Hi,
>
> Now that StashTreeValue has an entry pointer, value->setting_type and
> value->key_name can be dropped.

Yes.

> Also, the stash_tree_action:_get_iter_first, _iter_next should be
> written as gtk_tree_model_foreach(model, stash_tree_handle_pref,
> action). It's ~15% slower, but that doesn't matter any more.

I'm not sure that's really neater. If C had lambda support then yes. 
Casting to gpointer is ugly.

> And of course, stash_foreach_various_pref can be inlined into
> stash_tree_setup, and call stash_tree_append_pref directly, or
> even inline it too.

Not sure it's worth it, maybe.