[Geany-devel] --readonly handling

Dimitar Zhekov dimitar.zhekov at xxxxx
Fri Nov 18 17:44:56 UTC 2011

On Thu, 17 Nov 2011 21:07:41 +0100
Thomas Martitz <thomas.martitz at student.htw-berlin.de> wrote:

> Am 17.11.2011 19:20, schrieb Dimitar Zhekov:
> >
> > Is there any technical reason to check cl_options.readonly in
> > document.c, and clear it load_startup_files() [...]
> >
> In an earlier version it also worked when opening a .geany file (so all 
> session files would be opened readonly). As opening via socket also goes 
> through main_handle_filename() (and hopefully nothing else?), I guess 
> there's no real reason anymore.

Here's a small patch that cleanups readonly handling, and adds the
missing def_clo.readonly initializer, which was a bug. Tested with
normal and socket open.

BTW, -Wmissing-field-initializers displays a huge number of warnings in
highlightingmappings.h (fill_eol and merge), and no warnings in any
other source file (except def_clo above).

E-gards: Jimmy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: read-only-cleanup-2011-11-18.diff
Type: text/x-diff
Size: 2614 bytes
Desc: not available
URL: <http://lists.geany.org/pipermail/devel/attachments/20111118/daf77873/attachment.diff>

More information about the Devel mailing list