[Geany-devel] GIT commit mails format

[Enrico Tröger]

On Mon, 31 Oct 2011 15:29:08 -0700, Matthew wrote:

>On 10/31/2011 09:44 AM, Nick Treleaven wrote:
>> On 31/10/2011 15:07, Nick Treleaven wrote:
>>> On 31/10/2011 13:57, Matthew Brush wrote:
>>>>>>> I'm not sure we would see a flood on a merge, probably only one
>>>>>>> commit saying 'merged gtkbuilder branch'? The gtkbuilder commits
>>>>>>> should appear as they are committed, not on merge.
>>>>>>>
>>>>>>
>>>>>> I think when you merge it makes all the commits onto the branch
>>>>>> that was merged into also. At least this is what happened on the
>>>>>> xfce-commits list when one of the devs merged several branches
>>>>>> with a total of 800+ commits in them, each triggering a commit
>>>>>> mail :)
>>>
>>> Ok, but ideally it would do as I described, like the github commit
>>> list for the scintilla-update merge:
>>>
>>> https://github.com/geany/geany/commits
>>
>> Anyway I think the problem of only showing the first commit of the
>> push in the subject makes the commit mails harmful because changes
>> can easily be missed. This problem seems more important than the
>> potential flooding issue. In practice our branch merges likely
>> wouldn't have 800 commits.
>
>+1
>
>And if we do have a case where a massive amount of commits will happen 
>at once, we could just temporarily disable the commit mails or ask 
>Enrico to do it.  IIRC it would just be a matter of turning of the 
>webhook through Github admin settings and turning it back on
>afterwards.

Yes.

So I take this as a 'yes, turn it into something more similar to the
old SVN commit mails with diff, size-limited and a link to the web
repo'.
Will do this soon and announce it before and after. 


Regards,
Enrico

-- 
Get my GPG key from http://www.uvena.de/pub.asc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.geany.org/pipermail/devel/attachments/20111102/34072c62/attachment.pgp>