[Geany-devel] Make document_save_file() show the Save As dialog when necessary

[Nick Treleaven]

Hi all,
I've just made a commit which changes plugin API behaviour, which I 
think is necessary. Please see the full log message below for justification.

It's possible plugins may need updating, but after a quick grep it seems 
perhaps only the core Save Actions plugin. For auto-saving it may want 
to ignore documents without an absolute path to avoid showing the Save 
As dialog. I'll make this change next.

Note that file templates and other features (geanyVC?) create documents 
with a filename but no path, hence this change. Remembering to show the 
Save As dialog in all code for the same reason was not reliable enough. 
That code can now be removed, but won't cause users any problems if left.

On 02/11/2011 15:27, Nick Treleaven wrote:
>    Branch: refs/heads/master
>    Home:   https://github.com/geany/geany
>
>    Commit: de559ef5d4150e2485ef3ffb865e9c9d3249bcd8
>        https://github.com/geany/geany/commit/de559ef5d4150e2485ef3ffb865e9c9d3249bcd8
>    Author: Nick Treleaven<nick.treleaven at btinternet.com>
>    Date:   2011-11-02 (Wed, 02 Nov 2011)
>
>    Changed paths:
>      M src/build.c
>    M src/callbacks.c
>    M src/dialogs.c
>    M src/document.c
>
>    Log Message:
>    -----------
>    Make document_save_file() show the Save As dialog when necessary
>
> Previously an error message was shown if doc->file_name is NULL.
>
> The Save As dialog is now shown if the document does not have an
> absolute path. This is because the user should confirm where to save
> the document in this case.
>
> Although this changes plugin API behaviour, it seems the best way to
> ensure the Save As dialog is always shown when needed so the user
> knows where the document has been saved.