[Geany-devel] GProject geany-plugins integration

[Enrico Tröger]

On Thu, 26 May 2011 22:17:36 +0200, Enrico wrote:

>On Wed, 25 May 2011 00:41:22 +0200, Jiří wrote:
>
>>2011/5/23 Enrico Tröger <enrico.troeger at uvena.de>:
>>> On Mon, 23 May 2011 12:52:49 +0200, Jiří wrote:
>>>
>>>>2011/5/22 Enrico Tröger <enrico.troeger at uvena.de>:
>>>>> On Fri, 20 May 2011 22:04:40 +0200, Jiří wrote:
>>>>>
>>>>>>Hi,
>>>>>>
>>>>>>I've finally found some time to integrate my GProject plugin into
>>>>>>geany-plugins; for those who like git, the result is here:
>>>>>>
>>>>>>https://gitorious.org/geany-plugins-gproject/geany-plugins-gproject
>>>>>>
>>>>>>For those who dislike it, the patch is here:
>>>>>>
>>>>>>http://db.tt/esDNpPw
>>>>>
>>>>> I guess you waant to commit it yourself instead of depending on
>>>>> someone else, right?
>>>>> So, tell me your Sourceforge username and I'll add you to the
>>>>> project members.
>>>>
>>>>Thanks Enrico, my username is "techet".
>>>
>>> I added you to the project, so you can write to the repository.
>>> Have fun :D.
>>
>>Perfect! I've just committed the plugin. As I said, at the moment
>>there's a problem with the waf script - it compiles fine but I don't
>>know how to install the icons from the "icons" directory and how to
>>refresh the icon cache during installation. Any hints how to do this
>>with waf?
>
>I'll have a look on Sunday.

So I had and added the necessary bits, I hope.

I verified the icon installation on Linux and it works. I couldn't test
it on Windows as currently the SVN checkout on Windows is broken (see
thread "GeanyPG breaks SVN checkout on Windows" for more information).

Two remarks:
- why do you use these custom icons at all? At least the icons for
Reload, Collapse and Expand can be taken from the stock icons. Not
exactly sure about "Follow active editor", maybe there is something
appropriate on http://developer.gnome.org/gtk/2.24/gtk-Stock-Items.html.
Using the stock icons has the big advantage that these are provided by
the icon theme of the user, so they fit better than your custom icons.
Just an idea.

- #include <geany/geanyplugin.h>is wrong. On my system it didn't work
neither with autotools nor with Waf. The include path is wrong, just
omit the "geany" path part.
Attached is a patch to fix this.


Regards,
Enrico

-- 
Get my GPG key from http://www.uvena.de/pub.asc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gproject_header_include.patch
Type: text/x-diff
Size: 2180 bytes
Desc: not available
URL: <http://lists.geany.org/pipermail/devel/attachments/20110529/ac677d39/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.geany.org/pipermail/devel/attachments/20110529/ac677d39/attachment.pgp>