[Geany-devel] Split Window Patches

[Matthew Brush]

On 03/27/11 09:11, Colomban Wendling wrote:
> We need a better fix then. Maybe you can try to find out why the X
> clipboard get broken on Scintilla (and fix it :D). If it get fixed, we
> will probably can re-apply the patch.

When the ScintillaObject gets reparented (unrealized/re-realized), it 
doesn't re-setup the selection targets again (this is only done in 
ScintillaGTK::Initialize()).

The first patch #0001 is the same as the previous #0003 patch, which 
removes the reparenting stuff, to make Split Window work on Windows.

The second patch #0002 fixes the primary selection issue by moving 
gtk_selection_add_targets() and friends into the 
ScintillaGTK::RealizeThis() function, and also adds its counter-parts to 
the ScintillaGTK::UnRealizeThis() function.

The third patch #0003 fixes the issue where the I-Beam cursor is 
displayed even for the scrollbars when the widget is 
unrealized/re-realized.  I tried a few different ways to do this, 
including trying to use Scintilla's SetCursor() function, but nothing 
seemed to work.

Everything *seems* to work now, and it's not hacky, IMO - except maybe 
#0003 a little bit ;).

Cheers,
Matthew Brush
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Remove-widget-reparenting-in-Split-Window-plugin.patch
Type: text/x-patch
Size: 2582 bytes
Desc: not available
URL: <http://lists.geany.org/pipermail/devel/attachments/20110327/5bef4382/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Fix-Scintilla-primary-selection-on-reparent.patch
Type: text/x-patch
Size: 2112 bytes
Desc: not available
URL: <http://lists.geany.org/pipermail/devel/attachments/20110327/5bef4382/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Fix-scrollbar-cursors.patch
Type: text/x-patch
Size: 868 bytes
Desc: not available
URL: <http://lists.geany.org/pipermail/devel/attachments/20110327/5bef4382/attachment-0002.bin>