[Geany-devel] Webhelper Waf

[Enrico Tröger]

On Sun, 27 Mar 2011 17:38:57 +0200, Colomban wrote:

>Le 27/03/2011 12:50, Enrico Tröger a écrit :
>> On Sun, 27 Mar 2011 03:18:28 -0700, Matthew wrote:
>> 
>>> Hi,
>>>
>>> I have no idea about Waf, but I just updated Devhelp Waf script.  Is
>>> it ok?
>>>
>>> Also, Webhelper should need the attached update?
>> 
>> Your code checks for 'gthread-2.0' in the configure part. The result
>> is stored in 'GTHREAD'.
>> So, until this you only checked for the presence of the gthread-2.0
>> module, it isn't used at all so far.
>> 
>> To use it, i.e. to tell Waf it should add --cflags and --libs during
>> compilation/linking, you need to add GTHREAD to the list of
>> libraries in wscript_build.
>> 
>> Anyway, as I said in the g_thread_init() thread, I also think we
>> should initialise threads in Geany itself, so this patch isn't
>> needed anymore then.
>
>IIRC it is until I drop the g_thread_init() call in the plugin... maybe
>dropping it and depend on the new SVN revision is the better solution,
>since it maybe be a problem to initialize from plugins anyway.
>Any way to make the plugin depend on r5637?

Yeah, by requirement a certain GEANY_API_VERSION version which I didn't
update when adding the change...shame on me.

But soon I'll commit a new keybinding and then I'll increase the
GEANY_API_VERSION to 203, if that helps :D.


Regards,
Enrico

-- 
Get my GPG key from http://www.uvena.de/pub.asc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.geany.org/pipermail/devel/attachments/20110327/175c9a69/attachment.pgp>