[Geany-devel] Split Window Patches

[Matthew Brush]

Hi,

I've done some hacking on splitwindow.c and eliminated some bugs and 
added some features.  I checked the geany/geany-plugins feature/bug 
trackers and I'll list which of the items I think can be closed.

The patches:

#0001
Enable code folding on the split window.
Closes bug #3097780[1]

#0002
Enable Scintilla's default popup editor menu on the split window editor 
so that there's a way to copy/paste/undo/redo/etc.
Closes bug #2983145[2] although the keybindings and main menu items 
still don't work in the split window.

#0003
Remove the widget reparenting in an attempt to make the plugin work on 
Windows again.  Although I can't test on Windows, I think there's a good 
chance this will fix the issues and it seems to work fine on Linux as 
well.  I base this on an old GTK+ FAQ entry[3].
If someone can confirm, it will close bug #2725342[4] and the plugin can 
be re-enabled on the Windows build.

#0004
Fix confusing terminology in Split View menu, which has annoyed me for 
some time.
Closes bug #3203384[5] and feature request #2796316[6]

#0005
Stop unsplitting on document close unless there are no documents left 
open.  This patch just uses the first available document in the 
documents array instead of unsplitting when the document in the split 
window is closed.  I left a TODO comment in there, I'll fix it later 
unless someone else has the time.


While checking the bug/feature trackers, I noticed a few other items 
that can probably be closed.

Feature request #1530436[7]

Feature request #2969886[8] - based on the comments

Bug #2983106[9] - it's not impossible, Ctrl+Scroll works, just no 
keybindings and such.

Bug #2984797[10] - this one has bit me numerous times.  I honestly don't 
know if I fixed with my patches or if someone else fixed it in a recent 
revision, but it seem to no longer be reproducible for me.


[1] 
https://sourceforge.net/tracker/index.php?func=detail&aid=3097780&group_id=153444&atid=787791
[2] 
https://sourceforge.net/tracker/index.php?func=detail&aid=2983145&group_id=153444&atid=787791
[3] http://www.fifi.org/doc/libgtk1.2-doc/faq-html/gtkfaq-5.html#ss5.17
[4] 
https://sourceforge.net/tracker/index.php?func=detail&aid=2725342&group_id=153444&atid=787791
[5] 
https://sourceforge.net/tracker/?func=detail&aid=3203384&group_id=222729&atid=1056532
[6] 
https://sourceforge.net/tracker/index.php?func=detail&aid=2796316&group_id=153444&atid=787794
[7] 
https://sourceforge.net/tracker/index.php?func=detail&aid=1530436&group_id=153444&atid=787794
[8] 
https://sourceforge.net/tracker/index.php?func=detail&aid=2969886&group_id=153444&atid=787794
[9] 
https://sourceforge.net/tracker/index.php?func=detail&aid=2983106&group_id=153444&atid=787791
[10] 
https://sourceforge.net/tracker/index.php?func=detail&aid=2984797&group_id=222729&atid=1056532


Happy Coding,
Matthew Brush (codebrainz)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Enable-code-folding-on-splitview-window.patch
Type: text/x-patch
Size: 3423 bytes
Desc: not available
URL: <http://lists.geany.org/pipermail/devel/attachments/20110316/657ee846/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Enable-popup-edit-menu-on-splitview-window.patch
Type: text/x-patch
Size: 780 bytes
Desc: not available
URL: <http://lists.geany.org/pipermail/devel/attachments/20110316/657ee846/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Remove-widget-reparenting-in-Split-Window-plugin.patch
Type: text/x-patch
Size: 2582 bytes
Desc: not available
URL: <http://lists.geany.org/pipermail/devel/attachments/20110316/657ee846/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Fix-confusing-terminology-in-Split-Window-plugin-men.patch
Type: text/x-patch
Size: 1164 bytes
Desc: not available
URL: <http://lists.geany.org/pipermail/devel/attachments/20110316/657ee846/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-Stop-unsplitting-on-document-close-instead-use-first.patch
Type: text/x-patch
Size: 1333 bytes
Desc: not available
URL: <http://lists.geany.org/pipermail/devel/attachments/20110316/657ee846/attachment-0004.bin>