[Geany-devel] Ideas on increasing quality of plugins

[Colomban Wendling]

Le 12/03/2011 01:18, Lex Trotman a écrit :
>>> Maybe some other tests might be good, but I think this is a start.
>> I'd like to commit this to the Autotools build system:
>>
>> 1) run cppcheck on `make check`;
>> 2) enable by default, if compiler understands them, the following
>> warnings (discussed in other mails of this thread):
>>  * -Werror=implicit-function-declaration
>>  * -Werror=pointer-arith
>>  * -Wundef
>>  * -Wshadow
>>  * -Wwrite-strings
> 
> Good start.
Feel free to suggest more :)

>> There are currently 2 problems that would prevents the tests to pass:
>> 1) The debugger plugin don't compile with
>> -Werror=implicit-function-declaration (this should be fixed --
>> Alexander, could you fix them please?);
>> 2) cppcheck reports an error on geanylatex plugin; but I know Frank
>> already fixed this and so has probably only to import the fix in the
>> geany-plugins copy.
>>
>> 1 is really problematic since it require one to disable the debugger
>> plugin to be able to compiler the others,
> 
> Why do we have to disable the dubugger, sure it gives warnings, but
> for nightly builds and SVN builds thats ok, the disabling only comes
> at release time.
Since I set -W*error=*implicit-function-declaration, the implicit
function declaration warnings are treated as errors and then aborts the
build (unless one uses make -k of course).

We could downgrade this to a warning, but I think this is a problem
important enough to trigger an error.

Cheers,
Colomban