[Geany-devel] Real-time tag parsing (again) (was Geany FTW - better autocompletion)

Colomban Wendling lists.ban at xxxxx
Sun Jan 30 15:00:47 UTC 2011

Le 30/01/2011 14:44, Enrico Tröger a écrit :
>>>> However, I wonder why it was like it was before, was there a reason?
>>>> I mean, the variable (contextual_fake_count) pas properly
>>>> initialized, but in initialize*Parser() (which is called only once
>>>> per language). I feel weird about this being an accident... I see 3
>>>> possibilities:
>>>> 1) it was actually an accident, fixing it is good;
>>>> 2) the behavior of the tagmanager changed and initialise*Parser()
>>>> was used to be called before each parse, so fixing it is good;
>>>> 3) it was intentional for some reasons, so "fixing" it is probably
>>>> wrong.
>>>> As a possible reason for 3, I'd think that it was perhaps to avoid
>>>> having two anonymous symbols with the same name in a workspace. But
>>>> I don't see why it'd be a problem to have those "conflicts", since
>>>> name clash is not an issue with the TM workspace...
>>>> What do you know/think?
>>> Not sure.
>>> If I read the SVN log correctly, Nick committed it as backport of
>>> Anjuta code (svn diff -r1194:1195).
>> Right, thanks for finding the commit! :)
>> However, it doesn't easily tell which of the 3 possibilities is the
>> one, maybe initialize*Parser() used to be called before each and every
>> parsing. Or maybe Anjuta uses a separate process for tag parsing, in
>> which case it isn't a concern since it is automatically reset between
>> parsings?
> No idea, sorry.
> But I guess you tested your fix and didn't find any problems? If so, I
> think we should apply it.
Yep, I run this patch since I wrote it, and didn't noticed any problem :)


More information about the Devel mailing list