[Geany-devel] Broken geany-plugins build
enrico.troeger at xxxxx
Sun Aug 14 10:29:35 UTC 2011
On Sat, 13 Aug 2011 17:12:08 +0200, Colomban wrote:
>Le 13/08/2011 15:18, Enrico Tröger a écrit :
>> On Wed, 03 Aug 2011 15:20:26 +0000, colombanw at users.sourceforge.net
>>> Revision: 5882
>>> Author: colombanw
>>> Date: 2011-08-03 15:20:26 +0000 (Wed, 03 Aug 2011)
>>> Log Message:
>>> Only include config.h when building Geany
>>> config.h is not distributed, and we includ it from geany.h. Even
>>> though it was only included it HAVE_CONFIG_H was defined, an
>>> Autotools based build system is likely to define it, and it becomes
>>> a problem if that very build system uses another header name than
>>> Closes #3384026
>> While this was good to change, it broke building (probably) all
>> plugins of the geany-plugins project.
>> We would need to add
>> #include "config.h"
>> to the plugins' main source files to fix the build. This should not
>> be a big problem in most cases, before I do that, I would just see if
>> there are any objections
>> So, if any of the plugin maintainers, don't want that I touch their
>> code slightly, either tell me or fix it yourself.
I just did it, sorry guys :).
It's just a small change, so don't hit me too hard or just come around
and let's have a beer together.
I added the config.h include for all the plugins which could be built
on my system (all except DevHelp and GeanyCFP) and now the build of
geany-plugins succeed again (on my system).
However, some plugins compile without any change and without an
inclusion of config.h. I'm not entirely sure why but leave this to the
>Wooops, I didn't though it could break external plugins relying on
>implicit inclusion of config.h, my bad :/
Nah, rather the fault of the plugin authors, including me.
>BTW, I fixed my plugin(s), and I can help the fixing other if needed
>(though I doubt we need to be two doing this).
Get my GPG key from http://www.uvena.de/pub.asc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: not available
More information about the Devel