[Geany-devel] Broken geany-plugins build (was: Re: SF.net SVN: geany:[5882] trunk)
Frank Lanitz
frank at xxxxx
Sat Aug 13 22:17:58 UTC 2011
On Sat, 13 Aug 2011 15:18:18 +0200
Enrico Tröger <enrico.troeger at uvena.de> wrote:
> On Wed, 03 Aug 2011 15:20:26 +0000, colombanw at users.sourceforge.net
> wrote:
>
> >Revision: 5882
> > http://geany.svn.sourceforge.net/geany/?rev=5882&view=rev
> >Author: colombanw
> >Date: 2011-08-03 15:20:26 +0000 (Wed, 03 Aug 2011)
> >
> >Log Message:
> >-----------
> >Only include config.h when building Geany
> >
> >config.h is not distributed, and we includ it from geany.h. Even
> >though it was only included it HAVE_CONFIG_H was defined, an Autotools
> >based build system is likely to define it, and it becomes a problem if
> >that very build system uses another header name than config.h.
> >
> >Closes #3384026
>
> While this was good to change, it broke building (probably) all plugins
> of the geany-plugins project.
>
> We would need to add
> #include "config.h"
> to the plugins' main source files to fix the build. This should not be
> a big problem in most cases, before I do that, I would just see if
> there are any objections
>
> So, if any of the plugin maintainers, don't want that I touch their
> code slightly, either tell me or fix it yourself.
I hope I did fix it for all my plugins.
Cheers,
Frank
--
Frank Lanitz <frank at frank.uvena.de>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.geany.org/pipermail/devel/attachments/20110814/8b58d263/attachment.pgp>
More information about the Devel
mailing list