[Geany-devel] GProject - missing Geany patches

Matthew Brush mbrush at xxxxx
Tue Apr 26 12:30:07 UTC 2011

On 04/26/11 02:18, Jiří Techet wrote:
> On Sun, Apr 10, 2011 at 15:03, Jiří Techet<techet at gmail.com>  wrote:
> more than two weeks have passed without any response and I fear it
> will end the same way as many times before - that I post my patches,
> nobody looks at them and they get forgotten. I fully understand that
> people have limited time to work on geany (so do I), the problem is
> that most of the patches are 9 months old and they haven't been
> reviewed so far.

I think in addition to time constraints, the limited number of 
committers means that there's basically only 3 people who can/will 
review patches and commit the changes to the core code.

> Of course I understand that you may not want to have some patches
> merged to geany - just tell me and I'll either remove or rework them.
> I'd just like to get some sort of feedback - positive or negative.

Heh. I almost sent an identical sentence in a message to the ML a week 
ago, but then just decided to focus my (limited) development time elsewhere.

> Please let me know if there's anything I can help with to get the
> patches reviewed. Or, if you don't want my patches at all for some
> reason, please tell me as well so I stop spamming the mailing list
> with them.

My only suggestions, as someone without commit access, who is outside of 
the core developers, but who has submitted some patches are to file 
bug/feature reports on SourceForge so at least your patches won't get 
buried over time in the archives.  I can't imagine any of the developers 
searching through the ML archives for the word 'patches' to see what 
else they can review.

Another thing would be to send small digestible patches as attachments, 
or at least hyperlink to the exact commits, in your email/bug 
reports/feature requests.  Basically, if I was a committer with maybe an 
hour or two a week to review patches, I would not want to have to learn 
to use a new VCS, hunt down and clone a local repo, locate the 3 
commits, pull out patches for review, and *then* review them.

Of course, all of the above is just my personal observations from my 
short experiences with this project.

Best of luck,
Matthew Brush

More information about the Devel mailing list