[Geany-devel] [PATCH 05/19] Don't be annoying when not necessary

Nick Treleaven nick.treleaven at xxxxx
Thu Sep 16 14:54:44 UTC 2010


On Wed, 15 Sep 2010 23:15:05 +0200
Colomban Wendling <lists.ban at herbesfolles.org> wrote:

> >> When reloading a file with ctrl+R don't display the warning dialog
> >> that the unsaved changes might be lost when the file has not been
> >> modified.
> > 
> > I've been running with this patch for about a week. Looks good to me.
> This one seems to have been applied as r5190, and I have a little
> complain about it, so perhaps it would need a little more thought.
> 
> The problem is that reloading a document not only looses unsaved
> changes, but also undo/redo stack. This is particularly annoying if you
> hit the shortcut by accident (which I unfortunately did :( ).
> So I propose to two possible solutions:
> 1) simply check whether there's possible undo/redo, and if yes, ask
> before reloading (little patch joined);
> 2) the solution 1 fixes my problem, but probably not (?) for somebody
> that was annoyed by this dialog like Jiří was. So, perhaps a... setting
> (!) would be useful?

Applied, thanks. As Jiří said the patch was OK for him I think there's
no need for a pref.

Regards,
Nick



More information about the Devel mailing list