[Geany-devel] [PATCH 14/19] Rewrite tab switching queue

[Jiří Techet]

On Tue, Sep 14, 2010 at 16:41, Nick Treleaven
<nick.treleaven at btinternet.com> wrote:
> On Thu,  5 Aug 2010 01:59:48 +0200
> Jiří Techet <techet at gmail.com> wrote:
>
>> There was one more bug related to the tab switching. When we switch
>> so many times that we return back to the original document (so we
>> actually don't switch at all) then the following switch attempt
>> doesn't switch immediately to the next document.
>>
>> After spending two hours thinking what is wrong, I gave up and rewrote
>> the whole thing in a different way. The problem with the previous
>> implementation was that before you couldn't just look what's in the queue
>> "now" - you had to imagine what will be inserted there in the next step
>> because the switch_in_progress variable was set after the first switch
>> (this is also why I put the long comment why mru_pos = 2 - that is not
>> clear at all when you first look at it). Also there were some not very
>> nice "workarounds" like the idle function that was executed after the
>> switch and removed the double entry on top of the queue.
>>
>> So with the new implementation things are much simpler IMO. The queue
>> starts with the current document and the previously opened documments
>> follow. It's *always* like that, no exceptions. The idle function
>> is gone and cb_func_switch_tablastused() is simplified too. The rest of
>> the functionality should be clear from the code.
>
> Thanks, I'd like to commit this now. I realize it's been a while, but
> the patch doesn't apply cleanly and I can't see any commits since that
> would have caused conflicts. Any chance you could update and resubmit
> please?

Hi Nick,

no problem, I have just rebased all my patches on top of mainline.
This particular patch is attached. You can find the remaining pending
patches under for_review3 branch here:

http://gitorious.org/~techy/geany/gproject-geany

If you wish me to resubmit them by email, just tell me - I would
really like to see the patches extending geany's API to be a part of
mainline so my gproject plugin would not depend on patched geany and
could be moved among other plugins repository. By the way, the last
commit in my tree performes indentation based on regex matching as I
was proposing some time ago. I haven't published it yet because there
are already quite many of my patches pending here and I want them to
be reviewed first. Anyway, if you (or anyone else) are interested, you
can have a look.

Jiri


>
> Regards,
> Nick
> _______________________________________________
> Geany-devel mailing list
> Geany-devel at uvena.de
> http://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: tab_switching.patch
Type: text/x-patch
Size: 4030 bytes
Desc: not available
URL: <http://lists.geany.org/pipermail/devel/attachments/20100915/e7892281/attachment.bin>