[Geany-devel] [PATCH 19/19] Use per document indent sizes

Nick Treleaven nick.treleaven at xxxxx
Tue Sep 14 15:20:52 UTC 2010


On Mon, 9 Aug 2010 23:45:02 +0200
Jiří Techet <techet at gmail.com> wrote:

> I wanted to avoid 8 callback functions for each menu entry by reading
> the label but apparently it wasn't a good idea. When thinking about
> it, the label can be localized and completely changed so I shouldn't
> rely on its value.
> 
> Instead of using your patch I think it's cleaner to really use the 8
> callbacks which should fix all the problems. So please use the
> attached patch instead of the original one.

I've now applied the patch as (recently) updated by Erik for merge
conflicts, thanks.

I changed the code to use ui_menu_item_get_text() but not to translate
any indent width menu items.

Regards,
Nick



More information about the Devel mailing list