[Geany-devel] snippet keybindings? - Re: [PATCH] Some editor/snippets/keybindings enhancements

[Eugene Arshinov]

On Thu, 9 Sep 2010 11:41:10 +0100%
Nick Treleaven <nick.treleaven at btinternet.com> wrote:

> On Thu, 9 Sep 2010 11:01:04 +0400
> Eugene Arshinov <earshinov at gmail.com> wrote:
> 
> > > > OK, I didn't explain before what I had in mind but I think this
> > > > patch is too complex.
> > > > 
> > > > What I think we could accept is setting up the snippet
> > > > keybinding group size and items (like a plugin) when
> > > > snippets.conf is read, using any defaults found in the file. I
> > > > don't think we should write to snippets.conf. If the user wants
> > > > to set the keybinding in snippets.conf, then they must remember
> > > > that it won't be kept in sync with keybindings.conf. This
> > > > should make the code simpler.
> > > > 
> > > 
> > > No, I didn't mean to read/save keybindings in snippets.conf.  It
> > > is very strange that my patch does it, maybe I forgot to remove
> > > something from the code :)  I'll recheck the patch, probably
> > > tomorrow.
> > 
> > OK, it does not read keybindings from snippets.conf, only snippet
> > names. Maybe function names are confusing: if you look at
> > load_snippet_keybindings_from_snippets, you may think it really
> > loads keybindings, but it doesn't :)  Instead it reads just snippet
> > names and accordingly updates list of snippet keybindings available
> > in Preferences. 
> 
> BTW I replied to your first email before I saw this, sorry.
> 
> IIUC, I think it would make the code much simpler if the user has to
> say which snippets they want keybindings for, not offering all
> snippets for keybindings.
> 

Maybe, but what will the interface look like?