[Geany-devel] File type icons?

[Nick Treleaven]

On Tue, 26 Oct 2010 19:56:37 +0200
Colomban Wendling <lists.ban at herbesfolles.org> wrote:

> > You shouldn't put side effects into an assert statement because asserts
> > can be disabled. Fixed.
> Right, I didn't thought about that. But I' not sure it's a good idea to
> do the call twice, I'd think it's probably better to store the return
> value of gtk_icon_size_lookup() and check it, don't you think?
> We would have a less beautiful error message if the check fails, but in
> most cases we avoid to lookup the size twice.

You're right, it was a bit ugly. Now fixed.

Nick