[Geany-devel] insert line keybindings - Re: [PATCH] Some editor/snippets/keybindings enhancements

[Eugene Arshinov]

On Fri, 15 Oct 2010 18:45:11 +0100%
Nick Treleaven <nick.treleaven at btinternet.com> wrote:

> On Fri, 8 Oct 2010 06:03:33 +0400
> Eugene Arshinov <earshinov at gmail.com> wrote:
> 
> > > > The drawback of the first patch is that I doubt it's so
> > > > useful.  I know Vi[m] provides shortcuts for these actions ('o'
> > > > and 'O' in normal mode), but their necessity is questionable
> > > > for me.  I implemented this to ease XML editing with tag
> > > > autocompletion turned on.  Suppose you need to write to
> > > > consequent <li>'s.  Without this patch you need to press
> > > > End+Enter after writing the first <li> to place the cursor
> > > > where you need to start the second.  With my patch, you only
> > > > need to press one shortcut you can assign in Preferences >
> > > > Keybindings :)
> > > 
> > > Maybe we could add these. BTW you could use utils_get_eol_char().
> > > Also we already have sci_get_line_indent_position().
> > > 
> > 
> > I missed this function…  Updated patch attached.
> 
> Thanks. Committed with changes - moved keybindings to the Insert group
> and changed implementation a bit.
> 

Thanks for committing.  Your implementation using sci_send_command()
indeed looks better than mine.