[Geany-devel] snippet keybindings? - Re: [PATCH] Some editor/snippets/keybindings enhancements

[Eugene Arshinov]

On Fri, 8 Oct 2010 15:47:44 +0100%
Nick Treleaven <nick.treleaven at btinternet.com> wrote:

> On Fri, 8 Oct 2010 05:41:00 +0400
> Eugene Arshinov <earshinov at gmail.com> wrote:
> 
> > > The change was mainly to make editor_snippets_init() shorter for
> > > easier understanding. Now system keyfile snippet keybindings are
> > > supported too.
> > > 
> > 
> > Thanks for committing and improving the patch.
> > 
> > These is a little flaw in current editor.c:load_kb() function.  It
> > will probably segfault if snippets.conf does not contain Keybindings
> > section.  You should check if (keys != NULL) before doing
> > foreach_strv(ptr, keys).
> 
> foreach_strv is null safe since that commit ;-)
> 

Well, then it's another thing I missed :-)