[Geany-devel] snippet keybindings? - Re: [PATCH] Some editor/snippets/keybindings enhancements

[Eugene Arshinov]

Hi Nick

On Tue, 5 Oct 2010 12:10:08 +0100%
Nick Treleaven <nick.treleaven at btinternet.com> wrote:

> On Fri, 1 Oct 2010 16:12:40 +0100
> Nick Treleaven <nick.treleaven at btinternet.com> wrote:
> 
> > > Maybe we can incorporate the first patch into Geany?  "Power
> > > users" who need snippet keybindings will be able to specify
> > > keybindings manually in snippets.conf, just like hidden prefs in
> > > geany.conf.  This will keep the implementation simple, and
> > > ordinary users mostly likely do not need the keybindings.
> > 
> > Now committed but changed so the keybindings are only read from the
> > user keyfile. Thanks for the patches.
> 
> The change was mainly to make editor_snippets_init() shorter for
> easier understanding. Now system keyfile snippet keybindings are
> supported too.
> 

Thanks for committing and improving the patch.

These is a little flaw in current editor.c:load_kb() function.  It will
probably segfault if snippets.conf does not contain Keybindings
section.  You should check if (keys != NULL) before doing
foreach_strv(ptr, keys).

Best regards,
Eugene.