[Geany-devel] scintilla update - Re: scintilla rectangle selection change

[Nick Treleaven]

On Sun, 28 Nov 2010 14:04:37 +0100
Enrico Tröger <enrico.troeger at uvena.de> wrote:

> >> I committed the new Scintilla version into the unstable branch. I
> >> hope I did it right. The scintilla_changes.patch still needs to be
> >> updated, will do this sometime later, though there were no other
> >> changes I did to the sources, only removed unused lexers.
> >
> >Great. Looks like quite a big change (the directory structure changes).
> 
> Probably, although the big changes were in Scintilla. This time I just
> adopted the original directory structure from the Scintilla project.
> In the past, we merged the src and gtk folders into scintilla.

It's better the new way I think :)

> For the autotools based build system, I did it the easy way and used
> one Makefile in scintilla/ which builds all source files of the
> subdirectories instead of walking through the subdirectories.
> This might be not the autotools way but as I'm not that familiar with
> it, it was easier for me. 

Sounds Ok.

> >> There might be more work necessary like updating lexer constants like
> >> those for strings and comments in src/editor.c.
> >
> >BTW we moved the is_{comment,string,code}_style functions to
> >highlighting.c, and they're now in the plugin API. I thought it was
> 
> D'oh. I'm not up2date with the code anymore. Shame on me.

No, it was a recent change anyway.

Nick